A good rule of thumb is that shorts should end approximately two inches above the top of the kneecap. This tends to be a sweet spot for men who want true shorts, but not short shorts.